Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a broadcaster for range sensor #1091

Merged
merged 5 commits into from
Aug 15, 2023
Merged

add a broadcaster for range sensor #1091

merged 5 commits into from
Aug 15, 2023

Conversation

flochre
Copy link
Contributor

@flochre flochre commented Aug 2, 2023

Adding controller_interface/include/semantic_components/range_sensor.hpp

needed for : ros-controls/ros2_controllers#725

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #1091 (5173a5f) into master (925f5f3) will decrease coverage by 2.21%.
Report is 503 commits behind head on master.
The diff coverage is 34.83%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   34.61%   32.41%   -2.21%     
==========================================
  Files          52       94      +42     
  Lines        2981     9937    +6956     
  Branches     1855     6694    +4839     
==========================================
+ Hits         1032     3221    +2189     
- Misses        310      789     +479     
- Partials     1639     5927    +4288
Flag Coverage Δ
unittests 32.41% <34.83%> (-2.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controller_manager/src/controller_manager.cpp 37.94% <ø> (-1.77%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 46.76% <ø> (-6.87%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 69 more

... and 21 files with indirect coverage changes

christophfroehlich
christophfroehlich approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Concerning red CI: You (or the maintainers) can merge (or rebase) the master branch into this PR, this should fix the linter jobs.
I think the copyright owner is missing, and the linter might complain.

@flochre
Copy link
Contributor Author

flochre commented Aug 7, 2023

Up?
Is there still anything blocking?

saikishor
saikishor approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmagyar bmagyar added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Aug 15, 2023
@bmagyar
Copy link
Member

bmagyar commented Aug 15, 2023

I marked it for backporting to humble too

@bmagyar bmagyar closed this Aug 15, 2023
@bmagyar bmagyar reopened this Aug 15, 2023
@bmagyar bmagyar merged commit bcdc5bb into ros-controls:master Aug 15, 2023
2 checks passed
mergify bot pushed a commit that referenced this pull request Aug 15, 2023
@flochre @mergify
add a broadcaster for range sensor (#1091)
5d806ce 
(cherry picked from commit bcdc5bb)
@mergify mergify bot mentioned this pull request Aug 15, 2023
Merged
bmagyar pushed a commit that referenced this pull request Aug 24, 2023
@mergify
add a broadcaster for range sensor (#1091) (#1100)
541940b
@flochre flochre deleted the feature/add-range-sensor-broadcast branch September 5, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@arne48 arne48 Awaiting requested review from arne48

@destogl destogl Awaiting requested review from destogl

@livanov93 livanov93 Awaiting requested review from livanov93

@mhubii mhubii Awaiting requested review from mhubii

@progtologist progtologist Awaiting requested review from progtologist

@anfemosa anfemosa Awaiting requested review from anfemosa

@bmagyar bmagyar Awaiting requested review from bmagyar

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@harderthan harderthan Awaiting requested review from harderthan

@sachinkum0009 sachinkum0009 Awaiting requested review from sachinkum0009

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flochre @codecov-commenter @bmagyar @christophfroehlich @saikishor